-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS 15823 - Provider Core Training icon and wording #30734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eselkin We need to make sure that all content we are adding now is added in a way that that text will be resized properly for browser font settings - the typography updates the DST did allows for this sitewide but we need to make sure our individual products do as well. What this means is that <p>
tags should be the default and <div>
and <span>
should be used less often.
For the Provider core training, currently you have everything wrapped in a <div>
which has no default font size and will not resize according to browser settings. This screenshot is when I set everything to Very Large, notice how the provider name, direction link, etc are large but not "Provider core training":
By changing the wrapping tag to <p>
this has a font size of 1.06rem and will scale accordingly. Now "Provider core training" is large when I change my font settings:
NOTE: You may notice that some other elements in the listings also don't scale (address, phone descriptions). This I had already noted in a separate ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments
src/applications/facility-locator/tests/components/ProviderTraining.unit.spec.jsx
Show resolved
Hide resolved
src/applications/facility-locator/tests/components/ProviderTraining.unit.spec.jsx
Outdated
Show resolved
Hide resolved
src/applications/facility-locator/components/search-results-items/common/ProviderTraining.jsx
Outdated
Show resolved
Hide resolved
…-veterans-affairs/vets-website into VACMS-15823-training-icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the screenshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* with class/color and training wording * add testing for new componnent rendering inside other component * non-semantic markup * span
Summary
CCProviderResult.jsx
,UrgentCareResult.jsx
, andEmergencyCareResult.jsx
result items types.Related issue(s)
Testing done
Screenshots
Shows a provider with and without training
What areas of the site does it impact?
Facility Locator
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Will have to use review instance or local deployment of vets-website (Can't test on tugboat because of facility locator)
If running local vets-website, you can use
yarn watch --env api=https://dev-api.va.gov
and then go tohttp://localhost:3001/find-locations
if you have theMAPBOX_TOKEN
in your .env